Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: No quotes for the enum case according to typescriptlang.org #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ABartelt
Copy link

Hi there,

i think the enum transformers did a little bit too much. It added quotes around the enum case in typescript declartions like this:

declare namespace App.Enums {
  export enum AttachmentType { 'TRACE' = 'trace' };
  export enum CrawlerLevel { 'BASE' = 0, 'ONE' = 1, 'TWO' = 2, 'THREE' = 3, 'FOUR' = 4 };
}

but according to the typescript handbook the enum cases should miss the quotes! Like this:

declare namespace App.Enums {
  export enum AttachmentType { TRACE = 'trace' };
  export enum CrawlerLevel { BASE = 0, ONE = 1, TWO = 2, THREE = 3, FOUR = 4 };
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant