Fix query for translatable slug #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was an error with `$additionalQuery` for translatable slug e.g. example it was before fix: ```sql select * from `posts` where json_unquote(json_extract(`slug`, '$."nl"')) = '/' or json_unquote(json_extract(`slug`, '$."en"')) = '/' and `team_id` = 3 ``` it was `WHERE statement1 or statement2 and additionalStatement3` instead of `WHERE (statement1 or statement2) and additionalStatement3`
|
@freekmurze Is any chance to merge this PR? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was an error with
$additionalQueryfor translatable sluge.g. example it was before fix:
correct SQL should be
it was
WHERE statement1 or statement2 and additionalStatement3instead ofWHERE (statement1 or statement2) and additionalStatement3@freekmurze