Skip to content

Fix implicit nullable deprecation notice #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix implicit nullable deprecation notice #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Package.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public function shortName(): string
return Str::after($this->name, 'laravel-');
}

public function hasViews(string $namespace = null): static
public function hasViews(?string $namespace = null): static
{
$this->hasViews = true;

Expand All @@ -93,7 +93,7 @@ public function hasViews(string $namespace = null): static
return $this;
}

public function hasInertiaComponents(string $namespace = null): static
public function hasInertiaComponents(?string $namespace = null): static
{
$this->hasInertiaComponents = true;

Expand Down Expand Up @@ -218,7 +218,7 @@ public function hasRoutes(...$routeFileNames): static
return $this;
}

public function basePath(string $directory = null): string
public function basePath(?string $directory = null): string
{
if ($directory === null) {
return $this->basePath;
Expand Down
Loading