Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General readability/extendability improvements #145

Closed
wants to merge 0 commits into from
Closed

General readability/extendability improvements #145

wants to merge 0 commits into from

Conversation

stuart-elliott
Copy link

  • Splitting the Package class into traits to improve readability
  • Splitting the PackageServiceProvider into individual methods
  • All test back to green
  • Hope this helps :)

@freekmurze
Copy link
Member

Could you rebase against main?

@stuart-elliott
Copy link
Author

Could you rebase against main?

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuart-elliott @freekmurze