Skip to content

Commit

Permalink
Fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
riasvdv committed May 19, 2022
1 parent 5cde82b commit 80eefb5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,13 @@ jobs:
os: [ ubuntu-latest ]
php: [ 8.1, 8.0 ]
laravel: [ 8.*, 9.* ]
dependency-version: [ prefer-lowest, prefer-stable ]
include:
- laravel: 8.*
testbench: 6.*
- laravel: 9.*
testbench: 7.*

name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.dependency-version }} - ${{ matrix.os }}
name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.os }}

steps:
- name: Checkout code
Expand All @@ -39,7 +38,7 @@ jobs:
- name: Install dependencies
run: |
composer require "laravel/framework:${{ matrix.laravel }}" "orchestra/testbench:${{ matrix.testbench }}" --no-interaction --no-update
composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction
composer update --prefer-dist --no-interaction
- name: Execute tests
run: vendor/bin/phpunit
2 changes: 1 addition & 1 deletion tests/NavigationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function test_it_can_get_the_active_section()

public function test_it_returns_null_when_there_is_no_active_section()
{
$activeSection = (new Navigation($this->activeUrlChecker))->add('Home', '/')->activeSection();
$activeSection = (new Navigation($this->activeUrlChecker))->add('Home', 'home')->activeSection();

$this->assertNull($activeSection);
}
Expand Down

0 comments on commit 80eefb5

Please sign in to comment.