fix: move new param to the last position in analyticsClient

spatie · Jul 19, 2024 · df6db70 · df6db70
1 parent 15a7da5
commit df6db70
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/Analytics.php b/src/Analytics.php
@@ -225,8 +225,8 @@ public function get(
             $orderBy,
             $offset,
             $dimensionFilter,
-            $metricFilter,
-            $keepEmptyRows
+            $keepEmptyRows,
+            $metricFilter
         );
     }
 }
diff --git a/src/AnalyticsClient.php b/src/AnalyticsClient.php
@@ -36,8 +36,8 @@ public function get(
         array $orderBy = [],
         int $offset = 0,
         ?FilterExpression $dimensionFilter = null,
-        ?FilterExpression $metricFilter = null,
         bool $keepEmptyRows = false,
+        ?FilterExpression $metricFilter = null,
     ): Collection {
         $typeCaster = resolve(TypeCaster::class);
 
@@ -52,8 +52,8 @@ public function get(
             'offset' => $offset,
             'orderBys' => $orderBy,
             'dimensionFilter' => $dimensionFilter,
-            'metricFilter' => $metricFilter,
             'keepEmptyRows' => $keepEmptyRows,
+            'metricFilter' => $metricFilter
         ]);
 
         $result = collect();

diff --git a/tests/AnalyticsTest.php b/tests/AnalyticsTest.php
@@ -33,8 +33,8 @@
         [],
         0,
         null,
-        null,
         false,
+        null,
     ];
 
     $this
@@ -74,8 +74,8 @@
         ],
         0,
         null,
-        null,
         false,
+        null,
     ];
 
     $this
@@ -117,8 +117,8 @@
         ],
         0,
         null,
-        null,
         false,
+        null,
     ];
 
     $this
@@ -161,8 +161,8 @@
         ],
         0,
         null,
-        null,
         false,
+        null,
     ];
 
     $this
@@ -206,8 +206,8 @@
         ],
         0,
         null,
-        null,
         false,
+        null,
     ];
 
     $this
@@ -247,8 +247,8 @@
         ],
         0,
         null,
-        null,
         false,
+        null,
     ];
 
     $this
@@ -299,8 +299,8 @@
         ],
         0,
         null,
-        null,
         false,
+        null,
     ];
 
     $this
@@ -351,8 +351,8 @@
         ],
         0,
         null,
-        null,
         false,
+        null,
     ];
 
     $this
-Original file line number
+Diff line change
@@ Expand Up / @@ -33,8 +33,8 @@ @@
             [],
 ,
             null,
-            null,
             false,
+            null,
         ];
         $this
@@ Expand Down Expand Up / @@ -74,8 +74,8 @@ @@
             ],
 ,
             null,
-            null,
             false,
+            null,
         ];
         $this
@@ Expand Down Expand Up / @@ -117,8 +117,8 @@ @@
             ],
 ,
             null,
-            null,
             false,
+            null,
         ];
         $this
@@ Expand Down Expand Up / @@ -161,8 +161,8 @@ @@
             ],
 ,
             null,
-            null,
             false,
+            null,
         ];
         $this
@@ Expand Down Expand Up / @@ -206,8 +206,8 @@ @@
             ],
 ,
             null,
-            null,
             false,
+            null,
         ];
         $this
@@ Expand Down Expand Up / @@ -247,8 +247,8 @@ @@
             ],
 ,
             null,
-            null,
             false,
+            null,
         ];
         $this
@@ Expand Down Expand Up / @@ -299,8 +299,8 @@ @@
             ],
 ,
             null,
-            null,
             false,
+            null,
         ];
         $this
@@ Expand Down Expand Up / @@ -351,8 +351,8 @@ @@
             ],
 ,
             null,
-            null,
             false,
+            null,
         ];
         $this
@@ Expand Down @@