add grep to Support CenOS and remove the exsit hadoop tar file#20
Open
liyujiel wants to merge 2 commits intosparkonpower:masterfrom
Open
add grep to Support CenOS and remove the exsit hadoop tar file#20liyujiel wants to merge 2 commits intosparkonpower:masterfrom
liyujiel wants to merge 2 commits intosparkonpower:masterfrom
Conversation
|
The removal of existing hadoop tar file is located in wrong place. Also, there is no need to remove it. We can reuse it instead of downloading again. |
josiahsams
requested changes
Mar 9, 2017
setup.sh
Outdated
| cat temp | ||
| cat temp >> $log | ||
| echo "Kindly kill above running instance(s) else change port number in config file, then continue to run this script." | tee -a $log | ||
| echo "By Using: kill `sudo lsof -t -i:#PORT_NUM`" |
Contributor
There was a problem hiding this comment.
Kindly merge this statement to the earlier message like,
kill above running instance by issuing : "kill sudo lsof -t -i:#PORT_NUM"
else
change port number in config file, then continue with this script
| if [ $? -eq 0 ] | ||
| then | ||
| echo 'Deleting existing hadoop folder "'hadoop-${hadoopver}'" from '$i' '| tee -a $log | ||
| echo 'Deleting existing hadoop folder "'hadoop-${hadoopver}.tar.gz'" from '$i' '| tee -a $log |
Contributor
There was a problem hiding this comment.
Leaving out existing tar.gz files is done on purpose to minimize the overall time taken when setup scripts are re-executed.
| echo 'Deleting existing hadoop folder "'hadoop-${hadoopver}'" from '$i' '| tee -a $log | ||
| echo 'Deleting existing hadoop folder "'hadoop-${hadoopver}.tar.gz'" from '$i' '| tee -a $log | ||
| ssh $i "rm -rf ${WORKDIR}/hadoop-${hadoopver}" &>>/dev/null | ||
| ssh $i "rm -rf ${WORKDIR}/hadoop-${hadoopver}.tar.gz" &>>/dev/null |
kavanabhat
suggested changes
Mar 10, 2017
| cat temp >> $log | ||
| echo "Kindly kill above running instance(s) else change port number in config file, then continue to run this script." | tee -a $log | ||
| echo "By Using: kill `sudo lsof -t -i:#PORT_NUM`" | ||
| echo "By Using: kill \`sudo lsof -t -i:#PORT_NUM\`" |
There was a problem hiding this comment.
The suggestion was to merge the two echo statements into one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I try to implement it on CentOS based server. It shows couple errors.
Also add a help command for kill the exist port.