Support gsplat library compressed PLY output#39
Merged
Conversation
…rder to decode compressed PLY format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables Forge to decode both SuperSplat and gsplat library's compressed PLY output. When SuperSplat outputs a compressed PLY it includes the comment "Generated by SuperSplat 2...." which we had used to detect this file format. The rationale was that the "chunk" element could conceivably be used for some other reason in a PLY file, and relying on just the word "chunk" could result in a false positive and incorrect decoding.
It turns out the gsplat library also outputs this format and does NOT output any comment. I haven't seen any evidence that "chunk" is used in another way in a PLY file in a 3DGS context, so it feels relatively safe to ignore the comment. Verified that this fix does indeed allow loading a representative gsplat-output file (toy.ply in toy.zip from #34 ).