Replace THREE.Clock with THREE.Timer#378
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Spark with Three.js r183 or later a warning will be logged in the dev console that the
THREE.Clockclass has been deprecated. This PR replaces it withTHREE.Timerwhich is already available in core Three.js since r179, so should be usable in the entire supported version range of Spark (>= r180).The cloning is no longer needed as querying the elapsed time and/or delta time no longer updates the internal state. This also means that it can now properly be used for effect synchronization. Although in the various examples of Spark a custom time uniform seems to be consistently used making me wonder if the built-in approach should be better documented or alternatively scrapped entirely.