Skip to content

Implement forEachSplat and getBoundingBox for PagedSplats#324

Merged
dmarcos merged 1 commit into
sparkjsdev:mainfrom
mrxz:paged-for-each-splat
May 15, 2026
Merged

Implement forEachSplat and getBoundingBox for PagedSplats#324
dmarcos merged 1 commit into
sparkjsdev:mainfrom
mrxz:paged-for-each-splat

Conversation

@mrxz

@mrxz mrxz commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

This PR moves the forEachSplat method into the SplatSource interface, ensuring it works across PackedSplats, ExtSplats and PagedSplats. This allows the SplatMesh.forEachSplat and SplatMesh.getBoundingBox methods to work for paged splats (see #317).

These implementations are somewhat unintuitive for paged splats, as they depend on which splat pages happen to be loaded. This might confuse users, though arguably the current behaviour of no-op for forEachSplats isn't intuitive either.

@asundqui

Copy link
Copy Markdown
Contributor

That's great! Let's merge it I say! Surely someone will want to do this :) @dmarcos

@dmarcos
dmarcos merged commit 77b98aa into sparkjsdev:main May 15, 2026
2 checks passed
@dmarcos

dmarcos commented May 15, 2026

Copy link
Copy Markdown
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants