Add missing "three/addons" entry to importmap of splat-dissolve-effects example#310
Merged
Merged
Conversation
Contributor
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hosted version of the
splat-dissolve-effectsis currently broken due to a missing import map entry. Opening https://sparkjs.dev/examples/#splat-dissolve-effects logs the following error in the console:When using
npm run devthe error does not show up as Vite ignores the importmap and is able to properly resolve thethree/addon/import.This PR adds the missing entry to the importmap of the example, resolving the issue.