You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Outstanding (potentially A3D side things?) things not caught in this PR that in A3D code:
dynamically importing forge, as forge import is triggering server side rendering errors in Next.js setup
Some unresolved issues
handling spz file loading in electron -- the electron file reader works for uncompressed formats, doesn't for spz. I'm assuming might just need to repro the gunzip setup in forge but not super familiar with it.
loading multiple splats in the A3D entity setup causes rendering artefacts. Guess it might be related to the three.group.add(splat)/three.object3d().add(splat) hierarchy thing but don't have an isolated example yet
Dist is all the source files compiled to JS + dependencies put together. PR should be against src files. I see though the code related to workers might come from a dependency. Before a fix though would be cool to understand why those window.Worker are needed in the A3D context
Makes sense! I moved the object hierarchy change into src for now.
A3D uses next.js so it's basically this thread here. It seems like this might have been fixed on the next.js side 2 weeks ago but I did also try with npm install next@latest but that didn't help?
pausing on this for now given side discussion! ideally would have a more proper solution that avoids traversing scene hierarchy every time an object gets added 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP snippets for doing integration exercise with https://github.com/n0neye/A3D
Outstanding (potentially A3D side things?) things not caught in this PR that in A3D code:
Some unresolved issues
spz. I'm assuming might just need to repro the gunzip setup in forge but not super familiar with it.three.group.add(splat)/three.object3d().add(splat)hierarchy thing but don't have an isolated example yetSome needed features (for later)