Skip to content

simple pth LED (linked to 0.1 inch header footprint) #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 15, 2025

Conversation

lewispg228
Copy link
Member

No description provided.

-removed PROD_ID field from sym, as this is not associated with a specific part.
-saved in kicad 9.0
@nseidle
Copy link
Member

nseidle commented Apr 11, 2025

You'll need to rebase as this is conflicting with main.

Additionally, I'm hesitant to merge this. I worry a 0.1" pair of holes will mislead folks who think a 5mm LED will fit there. Could we instead pull in the silk/mechanical from our standard 5mm LED package and change the layer to Fab (or other) so that the designer is at least aware of potential collisions? This would additionally reinforce anode/cathode designations.

-removed PROD_ID field from sym, as this is not associated with a specific part.
-saved in kicad 9.0
@lewispg228 lewispg228 force-pushed the Generic_0.1inch_PTH_LED branch from 32c99fd to 89bb085 Compare April 11, 2025 20:26
@lewispg228
Copy link
Member Author

@nseidle I think I did this right (?) Could you please review and let me know if there are still any merge conflicts?

Also, I created a 3D-model for the PTH 5mm red led (using FreeCAD). I included those editable source files as well (".FCStd"). I wasn't sure if we are doing that for other 3D models. I can certainly remove if ya don't want this file filling up this repo (33KB).

image

Also, I "snipped" the legs, but I could include their full length if you think that makes more sense. Full length could be helpful for some to see the shorter leg for polarity, but then it doesn't look so good in the viewer.

Let me know and thanks!

@nseidle
Copy link
Member

nseidle commented Apr 15, 2025

Nice FreeCad model! I renamed to LED_5mm_PTH_Red_NoSilk. We'll likely need variants with different color, silk and/or courtyards in the future.

@nseidle nseidle merged commit 86e673f into main Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants