Do not allow dmiWrite to touch x0 #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1081,7 +1081,9 @@ class RegisterBase : public TreeNode | |||
| template <typename T> | |||
| void dmiWrite(T val, index_type idx = 0) | |||
| { | |||
| dmiWrite_(&val, sizeof(val), sizeof(val) * idx); | |||
| if (getID() || getGroupNum()) { | |||
There was a problem hiding this comment.
I don't like the idea of including RISC-V behavior in Sparta. Could we add a bool class member called writable_ that we can set at construction time?
kathlenemagnus
approved these changes
Dec 13, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Do not allow dmiWrite to touch x0 * Do not allow dmiWrite to touch x0 (address PR feedback) e736f0d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.