professor: add v2.5.6#5653
Open
wdconinc wants to merge 6 commits into
Open
Conversation
spackbot-triage
Bot
added
new-version
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Spack package recipe for professor to support newer upstream releases and to make the build/install process more reliable by controlling the build working directory and running the project’s ./configure script explicitly.
Changes:
- Added versions
2.3.4,2.4.2, and2.5.6(with checksums). - Added
gitandlist_urlmetadata to improve source discovery/dev workflows. - Adjusted build logic: patch Makefile
$(PWD)usage, run./configurefrom the staged source directory, then build/install.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bernhardkaindl
previously approved these changes
Jul 19, 2026
wdconinc
commented
Jul 20, 2026
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds to
professorthe newer version v2.5.6. This also fixes a few issues which likely explain why I could never get professor to build in the HEP stack: the Makefile seems to pick up the$PWDwhere you issue the spack command, unless we add a working_dir and/or replace the use of explicit$(PWD)with$(CURDIR)(https://stackoverflow.com/questions/52437728/what-is-the-difference-between-pwd-and-curdir). This now also explicitly calls the./configurescript (home-grown, not autotools).Test build (
dev_pathwith a fake 2.5.1, but it was a clean clone):