Open
Conversation
Copilot created this pull request from a session on behalf of
wdconinc
July 19, 2026 07:37
View session
spackbot-triage
Bot
added
the
update-package
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Removed the cached_property decorator from the available_sets method.
wdconinc
marked this pull request as ready for review
July 19, 2026 08:22
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the lhapdfsets Spack bundle package to allow sets= variant values to be treated as glob patterns matched against pdfsets.index, enabling a single variant value (e.g., CT14*) to select a family of PDF sets while preserving all and default behavior.
Changes:
- Update the
setsvariant description to reflect support for patterns. - Add
available_sets()andresolve_sets()helpers to map requested variant values to concrete set names with deduplication. - Switch
install()to useresolve_sets()for determining which sets to download/install.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat
lhapdfsetssets=values as glob patterns overpdfsets.indexinstead of exact names, so one variant value can select a class of PDF sets. Existingallanddefaultbehavior is preserved.setsvalue against indexed set names.allanddefaultas special cases.spack install lhapdfsets sets=CT14*This was tested with
sets=CT18*,MSHT20*and it downloaded a lot...