Skip to content

bzip2: use configured C compiler when editing Makefiles #5635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mathomp4 wants to merge 1 commit into from
+6 −4
Closed

bzip2: use configured C compiler when editing Makefiles #5635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions repos/spack_repo/builtin/packages/bzip2/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,12 @@ def patch(self):
if self.spec.satisfies("platform=windows"):
return

# bzip2 comes with two separate Makefiles for static and dynamic builds
# Tell both to use Spack's compiler wrapper instead of GCC
filter_file(r"^CC=gcc", "CC={0}".format(spack_cc), "Makefile")
filter_file(r"^CC=gcc", "CC={0}".format(spack_cc), "Makefile-libbz2_so")
# bzip2 comes with two separate Makefiles for static and dynamic builds.
# Tell both to use the configured C compiler instead of GCC. `spack_cc`
# is no longer injected as a package-module global during this phase.

@bernhardkaindl bernhardkaindl Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and spack_cc is still set and it and is documented in the spack documenation:

https://spack.readthedocs.io/en/latest/build_systems/makefilepackage.html#edit-makefile

So far, I was unable to find evidence that this change should be merged.

cc = self.compiler.cc
filter_file(r"^CC=gcc", "CC={0}".format(cc), "Makefile")
filter_file(r"^CC=gcc", "CC={0}".format(cc), "Makefile-libbz2_so")

# The Makefiles use GCC flags that are incompatible with PGI
if self.spec.satisfies("%nvhpc@:20.11"):
Expand Down
Loading