Skip to content

intel_oneapi_{ccl,compilers,dnn,ipp{,cp},dpl,mkl,tbb,vtune}: new versions#5625

Open
rliulin wants to merge 5 commits into
spack:developfrom
rliulin:feature/merge-forks
Open

intel_oneapi_{ccl,compilers,dnn,ipp{,cp},dpl,mkl,tbb,vtune}: new versions#5625
rliulin wants to merge 5 commits into
spack:developfrom
rliulin:feature/merge-forks

Conversation

@rliulin

@rliulin rliulin commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Pull request overview (moved from Copilot Review)

This PR updates Spack’s built-in Intel oneAPI package recipes to add newly released component versions (vtune, tbb, mpi, mkl, ipp/ippcp, dpl, dnn, compilers, ccl), keeping installer URLs/checksums current for oneAPI offline installers.

Changes:

  • Add new version(...) entries across multiple intel_oneapi_* packages.
  • Extend intel_oneapi_compilers versions metadata with the new 2026.1.0 compiler release.

It changes intel-oneapi-mpi@2021.18.0 without changing the version string from 748 to 749 sub-release:

+++ b/repos/spack_repo/builtin/packages/intel_oneapi_mpi/package.py
@@ -27,10 +27,11 @@ class IntelOneapiMpi(IntelOneApiLibraryPackage):

     version(
         "2021.18.0",
-        url="https://registrationcenter-download.intel.com/akdlm/IRC_NAS/1710a04f-08b7-4b46-a0a5-bd46a4ef4436/intel-mpi-2021.18.0.748_offline.sh",
-        sha256="a1d9bebb9112f166c1911371971ae03fecb447f58d9f28f5c8ecdf78fb697f29",
+        url="https://registrationcenter-download.intel.com/akdlm/IRC_NAS/f62e2cfe-82a9-480f-b6ca-51ad7cc799fc/intel-mpi-2021.18.0.749_offline.sh",
+        sha256="a2afb95b3b9f85b9ddd32171e940a7b7cc02d7bbd6dca9d77a7bd405f3d62b73",

@spackbot-triage spackbot-triage Bot added new-version Modifications to packages' `depends_on()` directives intel Related to Intel packages update-package Modifications to packages in the repository labels Jul 17, 2026
@spackbot-triage
spackbot-triage Bot requested a review from rscohn2 July 17, 2026 09:22
@bernhardkaindl bernhardkaindl changed the title Feature/merge forks intel_oneapi_{ccl,compilers,dnn,ipp{,cp},dpl,mkl,mpi,tbb,vtune}: new versions Jul 17, 2026
@bernhardkaindl
bernhardkaindl requested a review from Copilot July 17, 2026 09:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
repos/spack_repo/builtin/packages/intel_oneapi_vtune/package.py Adds vtune 2026.2.0 version metadata.
repos/spack_repo/builtin/packages/intel_oneapi_tbb/package.py Adds oneTBB 2023.1.0 version metadata.
repos/spack_repo/builtin/packages/intel_oneapi_mpi/package.py Adds MPI installer metadata (but currently introduces a duplicate version entry).
repos/spack_repo/builtin/packages/intel_oneapi_mkl/package.py Adds oneMKL 2026.1.0 version metadata.
repos/spack_repo/builtin/packages/intel_oneapi_ippcp/package.py Adds ippcp 2026.0.1 version metadata.
repos/spack_repo/builtin/packages/intel_oneapi_ipp/package.py Adds IPP 2026.0.1 version metadata.
repos/spack_repo/builtin/packages/intel_oneapi_dpl/package.py Adds a 2026.0.1 entry (but currently points to the IPP installer URL/checksum).
repos/spack_repo/builtin/packages/intel_oneapi_dnn/package.py Adds oneDNN 2026.0.1 version metadata.
repos/spack_repo/builtin/packages/intel_oneapi_compilers/package.py Adds compilers 2026.1.0 URLs/checksums to the versions list.
repos/spack_repo/builtin/packages/intel_oneapi_ccl/package.py Adds oneCCL 2022.1.0 version metadata.
Comments suppressed due to low confidence (1)

repos/spack_repo/builtin/packages/intel_oneapi_mpi/package.py:40

  • There are two version("2021.18.0", ...) entries. Spack requires unique version identifiers; the second definition will overwrite the first (or can lead to confusion about which installer/checksum is intended). If this PR is updating the 2021.18.0 installer build, replace the existing entry instead of adding a duplicate.
    version(
        "2021.18.0",
        url="https://registrationcenter-download.intel.com/akdlm/IRC_NAS/f62e2cfe-82a9-480f-b6ca-51ad7cc799fc/intel-mpi-2021.18.0.749_offline.sh",
        sha256="a2afb95b3b9f85b9ddd32171e940a7b7cc02d7bbd6dca9d77a7bd405f3d62b73",
        expand=False,
    )

    version(
        "2021.18.0",
        url="https://registrationcenter-download.intel.com/akdlm/IRC_NAS/1710a04f-08b7-4b46-a0a5-bd46a4ef4436/intel-mpi-2021.18.0.748_offline.sh",
        sha256="a1d9bebb9112f166c1911371971ae03fecb447f58d9f28f5c8ecdf78fb697f29",
        expand=False,
    )

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread repos/spack_repo/builtin/packages/intel_oneapi_dpl/package.py
@bernhardkaindl

bernhardkaindl commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@rliulin, thank you for updating the Intel ONEAPI packages!
Update: DPL using a copy-and-pased IPP version is fixed, comment is removed therefore.

@bernhardkaindl
bernhardkaindl marked this pull request as draft July 17, 2026 09:53
@bernhardkaindl bernhardkaindl changed the title intel_oneapi_{ccl,compilers,dnn,ipp{,cp},dpl,mkl,mpi,tbb,vtune}: new versions intel_oneapi_{ccl,compilers,dnn,ipp{,cp},dpl,mkl,tbb,vtune}: new versions Jul 17, 2026
@bernhardkaindl

bernhardkaindl commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

AFAICS, you just fixed up the duplicated intel_oneapi_mpi@2021.18.0 version. I agree that it is more economical to put the related version updates into one PR, as long as GitLab CI does not run problems when changing many things at once. Otherwise, it might indeed be easier to branch off some changes.

I was initially confused by the change, so I'd like to suggest for easier review of such changes, it would be good to re-base this PR on top of the latest develop instead of merging develop on top of it and to squash the commits you apply into one commit, preferably also when changing files that are previously changed by an earlier commit in this PR and use helpful commit messages.

@rscohn2
rscohn2 marked this pull request as ready for review July 17, 2026 11:09
@rscohn2

rscohn2 commented Jul 17, 2026

Copy link
Copy Markdown
Member

It looks good with the changes. Now we need to see if the new versions break anything in e4s so I removed draft. It would be better if your automated tool started with an up to date base version rather than merging changes afterwards.

@bernhardkaindl

Copy link
Copy Markdown
Contributor

I install-tested the new versions:

passed intel-oneapi-ccl@=2022.1.0
passed intel-oneapi-compilers
passed intel-oneapi-dnn@=2026.0.1
passed intel-oneapi-dpl@=2022.13.0
passed intel-oneapi-ipp@=2026.0.1
passed intel-oneapi-ippcp@=2026.0.1
passed intel-oneapi-mkl@=2026.1.0
passed intel-oneapi-mpi
passed intel-oneapi-tbb@=2023.1.0
passed intel-oneapi-vtune@=2026.2.0

@rscohn2

rscohn2 commented Jul 19, 2026

Copy link
Copy Markdown
Member

Fails looks like system issue with gitlab. I will rerun

Fetching changes with git depth set to 2...
Reinitialized existing Git repository in /builds/spack/spack-packages/.git/
Created fresh repository.
fatal: unable to access 'https://gitlab.spack.io/spack/spack-packages.git/': Could not resolve host: gitlab.spack.io (Could not contact DNS servers)
WARNING: Retrying...
Getting source from Git repository
00:09
Gitaly correlation ID: 01KXR2TNRHRS341NT6B5BF7E51
Fetching changes with git depth set to 2...
Reinitialized existing Git repository in /builds/spack/spack-packages/.git/
Created fresh repository.
fatal: unable to access 'https://gitlab.spack.io/spack/spack-packages.git/': Could not resolve host: gitlab.spack.io (Could not contact DNS servers)
Uploading artifacts for failed job
00:01
Uploading artifacts...
WARNING: /builds/spack/spack-packages/jobs_scratch_dir: no matching files. Ensure that the artifact path is relative to the working directory (/builds/spack/spack-packages) 
WARNING: /builds/spack/spack-packages/jobs_scratch_dir/e4s-rocm-external: no matching files. Ensure that the artifact path is relative to the working directory (/builds/spack/spack-packages) 
WARNING: /builds/spack/spack-packages/tmp/_user_cache/cache/patches: no matching files. Ensure that the artifact path is relative to the working directory (/builds/spack/spack-packages) 
WARNING: /builds/spack/spack-packages/tmp/_user_cache/cache/providers: no matching files. Ensure that the artifact path is relative to the working directory (/builds/spack/spack-packages) 
WARNING: /builds/spack/spack-packages/tmp/_user_cache/cache/tags: no matching files. Ensure that the artifact path is relative to the working directory (/builds/spack/spack-packages) 
ERROR: No files to upload                          
Cleaning up project directory and file based variables
00:01
ERROR: Job failed: exit code 128

@rscohn2

rscohn2 commented Jul 19, 2026

Copy link
Copy Markdown
Member

@spackbot run pipeline

@spackbot-app

spackbot-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

I've started that pipeline for you!

@rscohn2
rscohn2 enabled auto-merge (squash) July 21, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

intel Related to Intel packages new-version Modifications to packages' `depends_on()` directives update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants