meshioplusplus, py-meshioplusplus: new packages#5624
Open
loumalouomega wants to merge 7 commits into
Open
Conversation
spackbot-triage
Bot
added
new-package
CI's prechecks/style job flagged both package.py files for ruff format non-compliance on the multi-line variant() calls.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new Spack packages for the meshio++ project: a standalone CMake-built C/C++/Fortran library (meshioplusplus) and its Python bindings (py-meshioplusplus) built via scikit-build-core/pybind11.
Changes:
- Introduces
meshioplusplus(CMakePackage) with variants for optional Fortran interface, HDF5/netCDF/zlib backends, parallel backend selection, and in-memory mesh backend selection. - Introduces
py-meshioplusplus(PythonPackage) built from GitHub release archives, with variants wired into scikit-build-coreconfig_settingsto toggle native backends and add Python fallbacks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| repos/spack_repo/builtin/packages/py_meshioplusplus/package.py | Adds Python bindings package with scikit-build-core configuration settings and optional backend/fallback variants. |
| repos/spack_repo/builtin/packages/meshioplusplus/package.py | Adds standalone CMake package with variants for Fortran/C API and optional I/O backends/parallelism. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new packages for meshio++, a C++20 fork of the pure-Python
meshiomesh I/O library that adds a native core while keeping full Python-format-fallback compatibility.meshioplusplus(CMakePackage) — the standalone HPC-facing library: an installablelibmeshioplusplusC API (pure-C99 header, pkg-config +find_package(meshioplusplus)support) with an optional+fortranvariant for the OO Fortran 2008 module. Available from6.2.0, the first release with a C API/Fortran interface. Variants also cover the optional HDF5/netCDF/zlib format backends, the selectable parallel backend (auto/seq/stl/openmp/tbb), and the in-memory mesh backend (meshio/native/kratos, defaultnative).py-meshioplusplus(PythonPackage, scikit-build-core + pybind11) — the Python bindings (themeshioplusplusPyPI package). Available from6.0.0,6.1.0, and6.2.0. Samehdf5/netcdf/zlibvariants, threaded to the CMake configure viaconfig_settings, plus the matchingpy-h5py/py-netcdf4Python fallbacks.Both packages require a C++20 toolchain (
conflicts("%gcc@:9")) and are sourced from the GitHub release archive rather than PyPI, since6.0.0has no PyPI sdist.Fixes loumalouomega/meshioplusplus#3