Skip to content

upp: patch for Intel oneAPI support#5615

Open
AlexanderRichert-NOAA wants to merge 1 commit into
spack:developfrom
AlexanderRichert-NOAA:patch-41
Open

upp: patch for Intel oneAPI support#5615
AlexanderRichert-NOAA wants to merge 1 commit into
spack:developfrom
AlexanderRichert-NOAA:patch-41

Conversation

@AlexanderRichert-NOAA

Copy link
Copy Markdown
Contributor

This PR adds patching to enable Intel oneAPI support for the UPP package. Intel oneAPI support is in UPP develop but not any releases yet.

@spackbot-triage spackbot-triage Bot added the update-package Modifications to packages in the repository label Jul 16, 2026
@AlexanderRichert-NOAA

Copy link
Copy Markdown
Contributor Author

@spackbot fix style

@spackbot-app

spackbot-app Bot commented Jul 16, 2026

Copy link
Copy Markdown

Let me see if I can fix that for you!

@spackbot-app

spackbot-app Bot commented Jul 16, 2026

Copy link
Copy Markdown

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/upp/package.py
�[1;34m==> �[0mrunning ruff format
1 file left unchanged
�[1;34m==> �[0mrunning ruff check
�[1m�[91mF405 �[0m�[1m`spec` may be undefined, or defined from star imports�[0m
  �[1m�[94m-->�[0m repos/spack_repo/builtin/packages/upp/package.py:83:12
   �[1m�[94m|�[0m
�[1m�[94m82 |�[0m     def patch(self):
�[1m�[94m83 |�[0m         if spec.satisfies("^[virtuals=fortran] intel-oneapi-compilers"):
   �[1m�[94m|�[0m            �[1m�[91m^^^^�[0m
�[1m�[94m84 |�[0m             filter_file("Intel", "Intel|IntelLLVM", "CMakeLists.txt")
�[1m�[94m85 |�[0m             filter_file("Intel", "Intel|IntelLLVM", "sorc/ncep_post.fd/CMakeLists.txt")
   �[1m�[94m|�[0m

Found 1 error.
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I wasn't able to make any further changes, but please see the message above for remaining issues you can fix locally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant