Skip to content

arrow on darwin: patch libtool version check to match newer apple output#4153

Merged
rbberger merged 1 commit into
spack:developfrom
eugeneswalker:arrow-patch-apple-libtool-check
Apr 7, 2026
Merged

arrow on darwin: patch libtool version check to match newer apple output#4153
rbberger merged 1 commit into
spack:developfrom
eugeneswalker:arrow-patch-apple-libtool-check

Conversation

@eugeneswalker

Copy link
Copy Markdown
Contributor

Arrow package: update libtool -V validation to match what is given in newer Apple libtool

Fixes CI failure issue seen on recent develop pipeline:

CC @rbberger

@eugeneswalker eugeneswalker added the ci Related to CI/CD workflows and pipelines label Apr 7, 2026
@spackbot-triage spackbot-triage Bot added patch Modifications to packages' sets of defined patches update-package Modifications to packages in the repository and removed ci Related to CI/CD workflows and pipelines labels Apr 7, 2026
@eugeneswalker

eugeneswalker commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

@adamjstewart rightly point out that we should raise this on arrow's repo. So, let us not merge this yet.

Update: fixed here

@adamjstewart adamjstewart marked this pull request as draft April 7, 2026 18:13
@rbberger

rbberger commented Apr 7, 2026

Copy link
Copy Markdown
Member

Yeah, makes sense to instead use that patch from the MR. Also, there seems to be newer versions.

@eugeneswalker eugeneswalker force-pushed the arrow-patch-apple-libtool-check branch 2 times, most recently from 336d2ed to c29c559 Compare April 7, 2026 18:25
@eugeneswalker eugeneswalker marked this pull request as ready for review April 7, 2026 18:25
@eugeneswalker

Copy link
Copy Markdown
Contributor Author

@spackbot fix style

@spackbot-app

spackbot-app Bot commented Apr 7, 2026

Copy link
Copy Markdown

Let me see if I can fix that for you!

@spackbot-app

spackbot-app Bot commented Apr 7, 2026

Copy link
Copy Markdown

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/arrow/package.py
repos/spack_repo/builtin/packages/raja_perf/package.py
�[1;34m==> �[0mrunning flake8
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
�[1;34m==> �[0mstyle checks passed
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

Comment thread repos/spack_repo/builtin/packages/arrow/package.py Outdated
@eugeneswalker eugeneswalker force-pushed the arrow-patch-apple-libtool-check branch from 44d2997 to 5c2d543 Compare April 7, 2026 18:58
@eugeneswalker eugeneswalker force-pushed the arrow-patch-apple-libtool-check branch from fdd5fb4 to 7d0e9a5 Compare April 7, 2026 20:15
@eugeneswalker eugeneswalker requested a review from rbberger April 7, 2026 21:59
@eugeneswalker

Copy link
Copy Markdown
Contributor Author

All CI is green. Let's merge unless there are objections!

@rbberger rbberger merged commit 23529cf into spack:develop Apr 7, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Modifications to packages' sets of defined patches update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants