Conversation
Member
|
There seems to be some build failures in the mgard CUDA job |
kmorel
force-pushed
the
mgard-1-6-0
branch
3 times, most recently
from
01ecfae to
95653e2
Compare
Contributor
Author
Thanks for pointing this out, @vicentebolea. There was an issue with MGARD and recent versions of protobuf on CUDA. I've submitted a PR to MGARD to fix this. I've added the patch from that PR, and now at checks pass. Are we now ready to go? |
vicentebolea
reviewed
Jan 6, 2026
Also update the patches so that they get applied to the previous version (1.5) but not this one (as they are already applied).
alalazo
approved these changes
Jan 7, 2026
Contributor
Author
|
Thanks for the merge, @alalazo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also update the patches so that they get applied to the previous version (1.5) but not this one (as they are already applied).