Support for private repos #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyberboss
commented
Sep 25, 2023
|
pretty sure you can have ilke 1 free privat repo on github these days for testing purposes. |
You can have infinite |
Cyberboss
force-pushed
the
PrivateRepoSupport
branch
from
8909b39 to
7859514
Compare
|
Created some local test cases. Should work fine without issue |
- Use GitHub API for downloading files. - Use installation token when cloning and fetching repositories. - Remove unused function.
Cyberboss
force-pushed
the
PrivateRepoSupport
branch
from
7859514 to
40fa4f9
Compare
jupyterkat
requested changes
Oct 30, 2023
|
This fucked up in prod so I gotta figure that out too |
|
Tested and working! |
|
worth the weight 🏋️♂️ |
jupyterkat
approved these changes
Nov 18, 2023
| let data = download_url(installation, repo, &filename, &commit).await?; | ||
| file.write_all(&data).await?; | ||
| Ok(path) | ||
| /* local test requires commenting out the .installation(...) call in find_content(), a valid github token with access, and the following dep: actix-rt = "2.9.0" |
There was a problem hiding this comment.
nah, it could be used for reference for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested, tell me how.
Closes #26