Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic operator API #140

Merged
merged 10 commits into from
Feb 16, 2024
Merged

Basic operator API #140

merged 10 commits into from
Feb 16, 2024

Conversation

poszu
Copy link
Collaborator

@poszu poszu commented Oct 25, 2023

Closes #139

@poszu poszu force-pushed the 139-basic-service-operator-api branch from a92ecfd to ed689df Compare October 25, 2023 13:41
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (75f2917) 94.01% compared to head (49faffc) 94.04%.

Files Patch % Lines
service/src/service.rs 94.68% 5 Missing ⚠️
service/src/operator.rs 93.02% 3 Missing ⚠️
src/prove.rs 90.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   94.01%   94.04%   +0.02%     
==========================================
  Files          25       26       +1     
  Lines        3126     3239     +113     
==========================================
+ Hits         2939     3046     +107     
- Misses        187      193       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu poszu marked this pull request as ready for review October 26, 2023 06:58
@poszu poszu requested review from fasmat and dshulyak October 26, 2023 06:59
@poszu poszu force-pushed the 139-basic-service-operator-api branch from 7025220 to 862574a Compare November 1, 2023 11:19
@pigmej
Copy link
Member

pigmej commented Feb 12, 2024

@poszu we need to merge that for the upcoming 1:n post-service demos.

@pigmej pigmej self-requested a review February 15, 2024 12:13
@poszu poszu merged commit 5ee9822 into main Feb 16, 2024
17 of 18 checks passed
@poszu poszu deleted the 139-basic-service-operator-api branch February 16, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement basic operator API
2 participants