Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code duplication - PoET harness and client #253

Open
fasmat opened this issue Mar 2, 2023 · 1 comment
Open

Remove code duplication - PoET harness and client #253

fasmat opened this issue Mar 2, 2023 · 1 comment

Comments

@fasmat
Copy link
Member

fasmat commented Mar 2, 2023

Both spacemeshos/poet (see harness.go) and spacemeshos/go-spacemesh (see poet_test_harness.go) contain a harness that can be used for (integration) testing against poet.

It would be beneficial if we would consolidate these two into the poet/integration package.

Additionally the code for the HTTPPoetClient can be found in spacemeshos/go-spacemesh (see poet.go) and might make sense to move to the spacemeshos/poet repository as well.

Having the client in the poet repository would make maintenance of it easier, since it would force us (assuming we move the tests along with it) to update the client whenever we update the server.

@poszu
Copy link
Contributor

poszu commented May 24, 2023

The harness.go (whole integration/ dir) has already been removed from this repository some time ago.

Regarding moving the client to this repository - I'm not sure. Different use cases have different needs and it will be impossible to create a client fitting everybody.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants