[Merged by Bors] - Allow any scheme for http poet client and default to http #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
countvonzero
approved these changes
Mar 1, 2023
pigmej
approved these changes
Mar 1, 2023
countvonzero
reviewed
Mar 1, 2023
|
bors try |
tryBuild failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
## Motivation Closes #4102 ## Changes This changes HTTPPoetClient to only default to http as scheme if it isn't set in the address configuration. This allows to the node to connect to poet via https if it is set as part of the address. ## Test Plan - Existing tests pass - Added test to check if client defaults to http if not set ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Build failed: |
poszu
approved these changes
Mar 2, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
## Motivation Closes #4102 ## Changes This changes HTTPPoetClient to only default to http as scheme if it isn't set in the address configuration. This allows to the node to connect to poet via https if it is set as part of the address. ## Test Plan - Existing tests pass - Added test to check if client defaults to http if not set ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 3, 2023
## Motivation Closes #4102 ## Changes This changes HTTPPoetClient to only default to http as scheme if it isn't set in the address configuration. This allows to the node to connect to poet via https if it is set as part of the address. ## Test Plan - Existing tests pass - Added test to check if client defaults to http if not set ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Pull request successfully merged into develop. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4102
Changes
This changes HTTPPoetClient to only default to http as scheme if it isn't set in the address configuration. This allows to the node to connect to poet via https if it is set as part of the address.
Test Plan
TODO
DevOps Notes