fix: allow to manually run external contributors workflows #599
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changed the way we run the test workflow that requires secrets. Actually we should close contributors PRs and reopen ourselves to be able to run tests. That is a massive PITA. Dependabot PRs are also broken. This changes how we run this test workflow by using pull_request_target and then manually checking for permissions. We also always allow dependabot to run. So for an external contributor, our workflow would be: - external contributor fork the project and create a new PR targetting main - the test workflow run and fails - one internal maintainer review the PR - internal maintainers can retry the failed run if the PR looks safe - all green, we can merge
eliecharra
commented
Jan 23, 2025
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Check permission | ||
| if: steps.checkAccess.outputs.require-result == 'false' && github.actor != 'dependabot[bot]' |
There was a problem hiding this comment.
Allows dependabot to pass anyway. For anyone else, check if we have write access from the previous step, otherwise make the workflow fail with a few debug info about why.
peterdeme
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This changed the way we run the test workflow that requires secrets.
Actually we should close contributors PRs and reopen ourselves to be able to run tests. That is a massive PITA.
Dependabot PRs are also broken.
This changes how we run this test workflow by using pull_request_target and then manually checking for permissions. We also always allow dependabot to run.
So for an external contributor, our workflow would be:
Type of change
Checklists
Development
false.)go generateto make sure the docs are up to dateCode review