Project Bloodstone - sled 1.0 #1456
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloodstone: Fix typo in ARCHITECTURE.md
bloodstone: A few nits
Co-authored-by: Amar Singh <[email protected]>
…ed index+log approach
…btle race conditions that it flagged
…h number assumptions to pop out
…tivelySerialized in the debug log
…cific IO functionality
… more error source annotations, minor refactoring in IO paths
…ectories to single top level directory
…r necessary synchronization
deuszx
reviewed
Dec 28, 2024
| @@ -42,7 +42,7 @@ challenging to understand why something is failing these intense tests. | |||
| For better understanding test failures, please: | |||
|
|
|||
| 1. read the failing test name and output log for clues | |||
| 1. try to reproduce the failed test locally by running its associated command from the [test script](https://github.com/spacejam/sled/blob/main/.github/workflows/test.yml) | |||
| 1. try to reproduce the failed test locally by running its assocated command from the [test script](https://github.com/spacejam/sled/blob/main/.github/workflows/test.yml) | |||
There was a problem hiding this comment.
Suggested change
| 1. try to reproduce the failed test locally by running its assocated command from the [test script](https://github.com/spacejam/sled/blob/main/.github/workflows/test.yml) | |
| 1. try to reproduce the failed test locally by running its associated command from the [test script](https://github.com/spacejam/sled/blob/main/.github/workflows/test.yml) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.