Repository navigation
fix: restricted mark-as-read-on-scroll to items leaving at the top - #1278
Merged
spacecowboy merged 1 commit intoOct 20, 2026
Conversation
Items which left the viewport at the bottom - by scrolling back up, or by being pushed down when new items were synced in above them - were marked as read without ever having been scrolled past. trackVisibility now reports whether an item left at the top, and only those items are marked as read. Also removed the unreachable filter.unread branch, as the unread filter is always enabled.
Owner
|
Thanks @uplansible . LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Items which left the viewport at the bottom - by scrolling back up, or by being pushed down when new items were synced in above them - were marked as read without ever having been scrolled past.
trackVisibility now reports whether an item left at the top, and only those items are marked as read. Also removed the unreachable filter.unread branch, as the unread filter is always enabled.
Testing
Ran the fix as my daily reader on a Pixel 9 Pro (GrapheneOS, fdroid release build) since late August, updated to the current revision in mid-October. Items scrolled back down past the bottom edge, and items pushed down by a background sync, stayed unread; items scrolled past the top were marked as read as before.
Checklist
./gradlew ktlintFormatand committed the resultIf the Room schema changed: added aN/A, no schema changeMIGRATION_N_N+1inAppDatabase.ktIf the Room schema changed: added a migration test inN/A, no schema changeapp/src/androidTest/.../db/room/Screenshots (if UI change)
No visual change.