Do not encode URL in href for verification/password reset#34
Merged
PJB3005 merged 1 commit intospace-wizards:masterfrom Jan 19, 2026
Merged
Conversation
Encoding should only happen if we show the URL as text. Due to & being reserved by html (https://www.w3schools.com/html/html_entities.asp), it gets converted to "amp;" which some email clients (and rider) take litterly instead of decoding it to the right perams. Encoding should only happen if we are showing the link itself, as such i provided an extra link below just in case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encoding should only happen if we show the URL as text. Due to & being reserved by html (https://www.w3schools.com/html/html_entities.asp), it gets converted to "amp;" which some email clients (and rider) take litterly instead of decoding it to the right perams.
Encoding should only happen if we are showing the link itself INSIDE the final html, as such i provided an extra link below just in case.