[IMP] hr_attendance_kanban: Minor improvements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wizard view to show attendance type always when checking in. Attendance type on employee compute when attendance type is manually changed. Start and end time on wizard in separate compute to fix start time not getting a value after UserError is raised.
dbruehlmeier
merged commit a59d6c9
into
sozialinfo:HR-Kanban-Attendance-Initial-Version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix manual attendance modification keeps employee attendance type in sync. Also include test to prove it.
Ensure start time when checking out does not go empty after UserError is raised.
Always show Attendance Type on check in wizard