Fix single listing map popup image fallback#2849
Open
Arafat-plugins wants to merge 1 commit intosovware:developmentfrom
Open
Fix single listing map popup image fallback#2849Arafat-plugins wants to merge 1 commit intosovware:developmentfrom
Arafat-plugins wants to merge 1 commit intosovware:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
How to reproduce the issue or how to test the changes
This fixes the single listing map popup image not showing the correct listing image when a listing does not have a preview image.
Previously,
Directorist_Single_Listing::map_data()only checked the preview image and then fell back directly to the default image. Because of that, listings that had gallery images but no preview image still showed the fallbackgrid.jpgimage in the single listing map popup.This change updates the image fallback order in the single listing map data to:
It also uses
Helper::default_preview_image_src()for the default image source and escapes the rendered image output properly.Steps to reproduce
Locationsection, open the listing marker popup on the map.grid.jpgimage instead of the uploaded listing image.Expected result
If no preview image is set, the single listing map popup should use the first gallery image before falling back to the default image.
How to test the fix
Locationsection.Any linked issues
Support ticket:
Related screenshots:
Screenshot
Checklist