Fix missing nonce in regenerate pages action#2835
Open
Arafat-plugins wants to merge 2 commits intosovware:developmentfrom
Open
Fix missing nonce in regenerate pages action#2835Arafat-plugins wants to merge 2 commits intosovware:developmentfrom
Arafat-plugins wants to merge 2 commits intosovware:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
How to reproduce the issue or how to test the changes
This fixes the Directorist settings "Regenerate Pages" action failing because the admin AJAX request did not include
directorist_nonce.The PHP handler for
atbdp_upgrade_old_pagesalready verifiesdirectorist_nonce, but the settings manager JS only submitted theactionvalue. As a result, the request failed the security check and the UI showed a generic "Sorry, something went wrong" message.This change adds the missing
directorist_nonceto the admin settings AJAX request in both the normal and minified settings manager bundles.Directorist -> Settings -> Page Setup.Regenerate Pages.action=atbdp_upgrade_old_pagesdirectorist_nonce=<value>Any linked issues
Fixes # https://taiga-sovware-u10698.vm.elestio.app/project/directorist/issue/2874
Screenshot
Checklist