Skip to content

Fix: Node.js version upgrade and webpack configuration issues:#2339

Merged
obiPlabon merged 17 commits into
sovware:developmentfrom
RabbiIslamRony:node-update
May 22, 2025
Merged

Fix: Node.js version upgrade and webpack configuration issues:#2339
obiPlabon merged 17 commits into
sovware:developmentfrom
RabbiIslamRony:node-update

Conversation

@RabbiIslamRony
Copy link
Copy Markdown
Member

@RabbiIslamRony RabbiIslamRony commented May 8, 2025

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Security fix
  • Improvement
  • New Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Text changes
  • Other... Please describe:

Description

How to test the changes:

  1. Node.js Version Update
  • Update Node.js to version 22.15.0
  • Update npm to version 10.2.4
  • Run npm install to update dependencies
  • Verify no dependency conflicts
  1. Webpack Configuration Testing
  • Run npm run dev to test development build
  • Run npm run dev-vue to test Vue build
  • Run npm run prod to test production build
  • Verify no webpack configuration errors
  • Check if CSS and JS files are generated correctly
  1. RTL Support Testing
  • Verify RTL CSS files are generated correctly
  • Test the plugin with RTL language enabled
  • Check if all styles are properly mirrored
  1. Build Script Cleanup
  • Removed unnecessary blocks:build command from package.json
  • Verified that Gutenberg blocks are still building correctly through the main build process
  • Confirmed no functionality loss after removing the separate build command
  1. Unused Node Packages Remove package.json
  • @wordpress/icons
  • @wordpress/scripts
  • @wordpress/dependency-extraction-webpack-plugin
  1. The node_modules directory , the package-lock.json file, _build file have been added to the global .gitignore file

Any linked issues

Fixes #

Checklist

@RabbiIslamRony RabbiIslamRony requested a review from vairafiq as a code owner May 8, 2025 10:47
@RabbiIslamRony RabbiIslamRony changed the title New: This PR addresses Node.js version upgrade and webpack configuration issues: Fix: Node.js version upgrade and webpack configuration issues: May 8, 2025
Copy link
Copy Markdown
Collaborator

@syedgalib syedgalib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@obiPlabon
Copy link
Copy Markdown
Contributor

Looks good
image
It seems this file assets/css/support-v7-style.css is no longer needed, so it'd be best to remove all the references of this css.

@RabbiIslamRony
Copy link
Copy Markdown
Member Author

Looks good image It seems this file assets/css/support-v7-style.css is no longer needed, so it'd be best to remove all the references of this css.

@Armanul Need your feedback regarding this issue

@HeyMehedi
Copy link
Copy Markdown
Collaborator

HeyMehedi commented May 14, 2025

@RabbiIslamRony, could you please resolve the conflicts?

@RabbiIslamRony
Copy link
Copy Markdown
Member Author

RabbiIslamRony commented May 14, 2025

Looks good image It seems this file assets/css/support-v7-style.css is no longer needed, so it'd be best to remove all the references of this css.

Update: Remove support-v7 css

@obiPlabon During my discussion with Arman. We decided to skip the Directorist v7 support CSS in this PR. We will continue this support in a future PR

Copy link
Copy Markdown
Collaborator

@HeyMehedi HeyMehedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.
image

@iamibrahimriaz
Copy link
Copy Markdown
Collaborator

Although there are some Deprecation Warning. But works nicely. Good to go @RabbiIslamRony.

@RabbiIslamRony
Copy link
Copy Markdown
Member Author

Although there are some Deprecation Warning. But works nicely. Good to go @RabbiIslamRony.

Thank you for checking. I would like to mention that the Deprecation Warning was already visible in our previous Node version. If you fix this warning, we can open another PR for it. This issue is not related to the current PR

@Armanul46
Copy link
Copy Markdown
Collaborator

Works fine

@obiPlabon obiPlabon merged commit 771158b into sovware:development May 22, 2025
1 check failed
@RabbiIslamRony RabbiIslamRony self-assigned this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants