[SOU-551] 운영 DB 엔드포인트 변경 및 배포 테스트

[bum0w0]

Summary by CodeRabbit

릴리스 노트

• 기타 작업
  • 프로덕션 배포 워크플로우 트리거 메커니즘을 자동 실행에서 수동 실행으로 변경했습니다.

[coderabbitai]

요약

Walkthrough

GitHub Actions 워크플로우 트리거를 Pull Request 및 main 브랜치의 push 이벤트에서 수동 workflow_dispatch 트리거로만 변경했습니다. 작업이나 단계는 변경되지 않았으며, 이전의 자동 실행 흐름을 비활성화했습니다.

Changes

Cohort / File(s)	Summary
GitHub Actions 워크플로우 구성 .github/workflows/prod-cicd.yaml	워크플로우 트리거를 자동 이벤트(pull_request, push)에서 수동 workflow_dispatch만으로 변경하여 명시적 수동 실행만 가능하도록 수정

예상 코드 리뷰 노력

🎯 1 (Trivial) | ⏱️ ~3분

관련 가능성이 있는 PR

• [SOU-421] 프로덕션 서버 무중단 배포 구현 #211: 동일한 GitHub Actions 워크플로우 파일(.github/workflows/prod-cicd.yaml)의 트리거를 수정하되, 이 PR과 반대 방향으로 변경(수동에서 자동으로 전환)하므로 직접적인 관련성이 있습니다.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	PR 제목은 운영 DB 엔드포인트 변경 및 배포 테스트를 언급하지만, 실제 변경사항은 GitHub Actions 워크플로우 트리거를 수동 트리거로 변경하는 것입니다.	제목을 실제 변경사항을 반영하도록 수정하세요. 예: 'SOU-551 GitHub Actions 워크플로우를 수동 트리거로 변경' 또는 정확한 변경사항을 설명하는 제목으로 변경해야 합니다.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/SOU-551-update-secrets

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd75bd4dd3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

workflow_dispatch에서 배포 경로가 실행되도록 복원

on을 workflow_dispatch만 남기면 이 워크플로우의 이벤트 이름은 항상 workflow_dispatch가 되는데, 같은 파일의 docker-build/deploy 잡은 여전히 if: github.event_name == 'push'(44, 74행) 조건이라 수동 실행 시 항상 skip됩니다. 그 결과 이 커밋 이후 prod 파이프라인은 build만 돌고 이미지 푸시와 서버 배포가 전혀 수행되지 않아 운영 배포가 차단되므로, push 트리거를 유지하거나 조건식에 workflow_dispatch를 포함해야 합니다.

Useful? React with 👍 / 👎.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/prod-cicd.yaml:
- Line 4: The workflow was changed to manual trigger but the job conditionals
still check only for github.event_name == 'push', causing "Upload JAR",
"docker-build", and "deploy" to be skipped; update those job/step if expressions
(referencing the job names "Upload JAR", "docker-build", "deploy") to allow
workflow_dispatch as well (e.g. github.event_name == 'push' || github.event_name
== 'workflow_dispatch' or contains(fromJson('["push","workflow_dispatch"]'),
github.event_name)), and make the usage of github.event.head_commit.message
null-safe by guarding it (e.g. use github.event.head_commit &&
github.event.head_commit.message or provide a default empty string) wherever
github.event.head_commit.message is referenced.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 591419b5-db5d-4821-9ba6-43295de0051c

📥 Commits

Reviewing files that changed from the base of the PR and between 2f0551b and fd75bd4.

📒 Files selected for processing (1)

• .github/workflows/prod-cicd.yaml

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

수동 트리거 전환으로 배포 파이프라인이 사실상 멈춥니다.

Line 4에서 이벤트를 workflow_dispatch만 받도록 바꿨는데, Line 36/44/74가 여전히 github.event_name == 'push'라서 Upload JAR, docker-build, deploy가 전부 스킵됩니다. 또한 Line 97의 github.event.head_commit.message는 수동 실행에서 비어 있을 수 있습니다.

🔧 제안 수정안

 on:
   workflow_dispatch:

@@
       - name: Upload JAR
-        if: github.event_name == 'push'
+        if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }}
         uses: actions/upload-artifact@v4
@@
   docker-build:
     needs: build
-    if: github.event_name == 'push'
+    if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }}
     runs-on: ubuntu-latest
@@
   deploy:
     needs: docker-build
-    if: github.event_name == 'push'
+    if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }}
     runs-on: ubuntu-latest
@@
       - name: Deploy to GCP Server
         uses: appleboy/[email protected]
         env:
-          COMMIT_MSG: ${{ github.event.head_commit.message }}
+          COMMIT_MSG: ${{ github.event.head_commit.message || github.sha }}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/prod-cicd.yaml at line 4, The workflow was changed to
manual trigger but the job conditionals still check only for github.event_name
== 'push', causing "Upload JAR", "docker-build", and "deploy" to be skipped;
update those job/step if expressions (referencing the job names "Upload JAR",
"docker-build", "deploy") to allow workflow_dispatch as well (e.g.
github.event_name == 'push' || github.event_name == 'workflow_dispatch' or
contains(fromJson('["push","workflow_dispatch"]'), github.event_name)), and make
the usage of github.event.head_commit.message null-safe by guarding it (e.g. use
github.event.head_commit && github.event.head_commit.message or provide a
default empty string) wherever github.event.head_commit.message is referenced.