-
Notifications
You must be signed in to change notification settings - Fork 14
feat: tx error producer #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
@@ -1,25 +1,4 @@ | |||
FROM golang:1.23.8 as builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might wanna have a separate dockerfile for the tx listener
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right. After double checking the binary size, it's surprisingly large (140M). I'll revise that
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #51 +/- ##
==========================================
- Coverage 45.06% 44.70% -0.36%
==========================================
Files 221 222 +1
Lines 13293 13474 +181
==========================================
+ Hits 5990 6024 +34
- Misses 6847 6992 +145
- Partials 456 458 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What:
This PR introduces a new utility which listens to Tx events published by SourceHub and relays them to Source's event queue (kafka).
Why:
SourceHub txs are executed upon block proposal as part of ABCI.
As consequence, tx errors are not written to the usual log stream, it's possible to recover these messages by setting error log to debug, but far too much noise comes along with it.
Furthermore, there are advantages to separating operational logs to application logs.
This approach solves these problems by directly extracting the logs from CometBFT events and writes it to a readily accessible event infrastructure which can be used to explore errors.