fix: Define field args in deterministic order #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
requested review from
orpheuslummis,
jsimnz,
fredcarle and
shahzadlone
shahzadlone
approved these changes
Jul 14, 2022
fredcarle
pushed a commit
that referenced
this pull request
Apr 25, 2023
* Define field arguments in a deterministic order * Yield introspected input fields in deterministic order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves graphql-go#636
Defines field args in deterministic order (alpha-numeric descending) - this means that the users will (unless their client further shuffles these) view the field args in a deterministic order. Also massively helps testing.