-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Svelte: add repo header dropdown menu #63257
Conversation
--dropdown-padding-y: 0.375rem; | ||
--dropdown-item-padding-y: 0.375rem; | ||
--dropdown-item-padding-x: 0.75rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increased these to match the designs.
@taiyab small design feedback: with the menu open, that part of the page looks pretty busy and the dropdown menu does not stand out well against the file tree. This is especially true in dark mode (visible in the screenshot). Maybe a more aggressive shadow? Or a different placement of the menu? |
911b5a7
to
16482b7
Compare
client/web-sveltekit/src/routes/[...repo=reporev]/RepoMenu.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could consider to have RepoMenu
take in a Repository
GraphQL object and have it define it's own dependencies in a fragment. That would mean the component needs to compute values such as the repo URL and the display name itself but it would be more encapsulated.
No strong feelings about either solution though.
client/web-sveltekit/src/routes/[...repo=reporev]/layout.spec.ts
Outdated
Show resolved
Hide resolved
@camdencheek I've added an updated shadow style to the menus, both for light and dark, which should help differentiate it from the background. |
Much better, thanks! |
cef6341
to
c41656c
Compare
Stacked on #63253
Completes SRCH-22 (at least most of it)
Unimplemented from the designs:
This adds the dropdown menu for the repo name button.
And the overflow menu (contains some icon and padding changes):

Test plan
Manual testing of buttons, links, and keyboard shortcuts. Added playwright tests for the meaningful interactions with this menu.