chore: log to file instead of printing #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmudar
reviewed
Oct 21, 2025
burmudar
reviewed
Oct 21, 2025
Co-authored-by: William Bezuidenhout <[email protected]>
Co-authored-by: William Bezuidenhout <[email protected]>
burmudar
reviewed
Oct 21, 2025
burmudar
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would print log messages, which can interrupt the user flow, as reported in #21.
This PR changes the behavior, so that log messages go to a log file. We still use
vim.notifyto display when the CLI is connected. User notifications should use notify, and usual logging should go to a log file.Closes #21