Rework moodle unpack #329
Open
Rework moodle unpack #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexstaeding
force-pushed
the
feature/moodle-unpack-rework
branch
from
1c9518f to
a400524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The moodle unpack feature has been long overdue for a bit of a rework.
One of the main (and longstanding) issues is the hardcoded assignment id (#233).
Ideally, the assignment id prefix (by default 'h') would be configured by a grader. Since graders can each require their own assignment id format and jagr currently supports running multiple graders in a single batch, this is not compatible with a single top-level configuration, for example in
jagr.conf.Unfortunately, without a major rework, configuring this from within a grader jar is not an option, because the grading batch (and thus the graders) are only loaded after the moodle unpack has finished.
The solution I am exploring in this PR is a separate configuration that must be explicitly loaded.
This new configuration is fundamentally decoupled with the main top-level configuration, and can be distributed alongside the moodle zips.
Fixes #233