Skip to content

Remove Interpreter and Testing Refactor #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Apr 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
8fef11f
Relocate svmc repl prompt
leeyi45 Mar 3, 2025
81f19d0
Run format
leeyi45 Mar 3, 2025
423bff4
Remove interpreter
leeyi45 Mar 3, 2025
2066efa
Remove interpreter and refactor tests
leeyi45 Mar 3, 2025
74333aa
Update tsconfig and certain test files
leeyi45 Mar 3, 2025
623a6c6
Further remove references to concurrent
leeyi45 Mar 3, 2025
2a44e60
updated snapshots to use unix-style paths
martin-henz Mar 4, 2025
3820363
Merge remote-tracking branch 'origin/master' into remove-concurrent
leeyi45 Mar 4, 2025
ed8eb2c
Add tests for parser rules
leeyi45 Mar 4, 2025
f98dcea
Revert "Add tests for parser rules"
leeyi45 Mar 7, 2025
7f2d14d
Merge branch 'master' into remove-concurrent
leeyi45 Mar 14, 2025
96fda16
Move rule type into parser
leeyi45 Mar 14, 2025
c16eddf
Move parser rules to RuleError
leeyi45 Mar 14, 2025
88a93af
Updating tests
leeyi45 Mar 16, 2025
95ccecd
Update ast helpers
leeyi45 Mar 16, 2025
b4de94d
Refactor runners to include execution method tests
leeyi45 Mar 17, 2025
a0c588e
Run format
leeyi45 Mar 17, 2025
bc990b4
Simplify determineExecutionMethod
leeyi45 Mar 17, 2025
d5bc34a
Fix broken cse-machine tests
leeyi45 Mar 19, 2025
853c8d3
Merge commit '716c3b976b301a10c90161ff366834db49f40ab7' into remove-c…
leeyi45 Mar 20, 2025
d0b91b5
Update parser tests to use simpler snapshots
leeyi45 Mar 27, 2025
414814d
Rename test functions and assertions
leeyi45 Apr 1, 2025
c912a24
Run format
leeyi45 Apr 1, 2025
0282ee8
Merge remote-tracking branch 'origin/master' into remove-concurrent
leeyi45 Apr 2, 2025
1f8e451
Add a script that makes running jest on windows easier
leeyi45 Apr 3, 2025
3efe0cf
Update previously broken tests relating to display
leeyi45 Apr 4, 2025
7ad774c
Add tests for testing utils
leeyi45 Apr 4, 2025
995a43e
Fix test utils not correctly handling snapshot names
leeyi45 Apr 4, 2025
e144dce
Add some missing tests to modules preprocessor
leeyi45 Apr 4, 2025
c40bd4f
Fix some potentially misleading tests that were passing
leeyi45 Apr 4, 2025
9653586
Remove deprecated code
leeyi45 Apr 5, 2025
b1b3827
Miscellanous changes
leeyi45 Apr 7, 2025
dd38f7b
Convert more scripts to js
leeyi45 Apr 10, 2025
6db5d8e
Remove depcreated sicp-prepare code
leeyi45 Apr 10, 2025
97b6a1e
Update benchmark testing script
leeyi45 Apr 16, 2025
9cdec12
Fix the broken benchmark tests
leeyi45 Apr 16, 2025
e30c881
Merge branch 'master' into remove-concurrent
martin-henz Apr 16, 2025
c689a90
Update tests
leeyi45 Apr 17, 2025
b751a15
Merge branch 'remove-concurrent' of github.com:source-academy/js-slan…
leeyi45 Apr 17, 2025
603b531
Add devEngines to package json
leeyi45 Apr 17, 2025
7798308
Refactor typed modules tests
leeyi45 Apr 18, 2025
ea999b5
Merge branch 'remove-concurrent' of github.com:source-academy/js-slan…
leeyi45 Apr 18, 2025
b45dab2
Merge remote-tracking branch 'origin/master' into remove-concurrent
leeyi45 Apr 18, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ You can set additional options:
Usage: js-slang [PROGRAM_STRING] [OPTION]

-c, --chapter=CHAPTER set the Source chapter number (i.e., 1-4) (default: 1)
-v, --variant=VARIANT set the Source variant (i.e., default, interpreter, substituter, typed, concurrent, wasm) (default: default)
-v, --variant=VARIANT set the Source variant (i.e., default, interpreter, substituter, typed, wasm) (default: default)
-h, --help display this help
-e, --eval don't show REPL, only display output of evaluation
```
Expand All @@ -81,7 +81,6 @@ Currently, valid CHAPTER/VARIANT combinations are:
- `--chapter=2 --variant=interpreter`
- `--chapter=2 --variant=typed`
- `--chapter=3 --variant=default`
- `--chapter=3 --variant=concurrent`
- `--chapter=3 --variant=interpreter`
- `--chapter=3 --variant=typed`
- `--chapter=4 --variant=default`
Expand Down
32 changes: 0 additions & 32 deletions docs/lib/concurrency.js

This file was deleted.

62 changes: 0 additions & 62 deletions docs/md/README_3_CONCURRENT.md

This file was deleted.

10 changes: 0 additions & 10 deletions docs/md/README_CONCURRENCY.md

This file was deleted.

4 changes: 0 additions & 4 deletions docs/md/README_top.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ the members of our learning community.

#### <a href="source_2_typed/">Source §2 Typed</a>

#### <a href="source_3_concurrent/">Source §3 Concurrent</a>

#### <a href="source_3_typed/">Source §3 Typed</a>

#### <a href="source_4_typed/">Source §4 Typed</a>
Expand All @@ -58,8 +56,6 @@ the Source Academy.

#### <a href="source_2_typed.pdf">Specification of Source §2 Typed</a>

#### <a href="source_3_concurrent.pdf">Specification of Source §3 Concurrent</a>

#### <a href="source_3_typed.pdf">Specification of Source §3 Typed</a>

#### <a href="source_4_typed.pdf">Specification of Source §4 Typed</a>
Expand Down
2 changes: 1 addition & 1 deletion docs/specs/Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
PDFLATEX = latexmk -pdf

SPECSNUMS = 1 1_wasm 1_type_inference 1_infinite_loop_detection 1_typed 2 2_typed 3_type_inference 3 3_concurrent 3_typed 4 4_explicitcontrol 4_typed styleguide 2_stepper studio_2 python_1
SPECSNUMS = 1 1_wasm 1_type_inference 1_infinite_loop_detection 1_typed 2 2_typed 3_type_inference 3 3_typed 4 4_explicitcontrol 4_typed styleguide 2_stepper studio_2 python_1

SPECS = $(SPECSNUMS:%=source_%)

Expand Down
106 changes: 0 additions & 106 deletions docs/specs/source_3_concurrent.tex

This file was deleted.

9 changes: 0 additions & 9 deletions docs/specs/source_concurrency.tex

This file was deleted.

3 changes: 2 additions & 1 deletion eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default tseslint.config(
},
...tseslint.configs.recommended,
{
files: ['**/*.ts*'],
files: ['**/*.ts*', 'scripts/*.mjs'],
languageOptions: {
globals: {
...globals.node,
Expand All @@ -32,6 +32,7 @@ export default tseslint.config(
'import/order': 'warn',
'@typescript-eslint/no-base-to-string': 'off', // TODO: Remove
'prefer-const': 'off', // TODO: Remove
'no-constant-condition': ['warn', { checkLoops: false }],
'no-var': 'off', // TODO: Remove
'@typescript-eslint/ban-ts-comment': 'warn',
'@typescript-eslint/ban-types': 'off',
Expand Down
22 changes: 15 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@
"eslint": "eslint src",
"format": "prettier --write \"src/**/*.{ts,tsx}\"",
"format:ci": "prettier --list-different \"src/**/*.{ts,tsx}\"",
"test": "jest",
"test-coverage": "jest --coverage",
"test": "node ./scripts/run_jest.mjs",
"test-coverage": "yarn test --coverage",
"docs": "node ./scripts/docs.mjs docs",
"jsdoc": "node ./scripts/docs.mjs",
"autocomplete": "node ./scripts/docs.mjs autocomplete",
"build_sicp_package": "./scripts/build_sicp_package.sh",
"build_sicp_package": "yarn build && node ./scripts/build_sicp_package.mjs",
"publish_sicp_package": "./scripts/publish_sicp_package.sh",
"benchmark": "jest --runInBand --testPathPattern='.*benchmark.*' --testPathIgnorePatterns='/dist/'",
"benchmark": "node ./scripts/run_jest.mjs --runInBand --testPathPattern='.*benchmark.*' --testPathIgnorePatterns='/dist/'",
"prepare": "husky install"
},
"devDependencies": {
Expand Down Expand Up @@ -85,6 +85,14 @@
"typescript": "^4.0.3",
"typescript-eslint": "^8.8.1"
},
"devEngines": {
"packageManager": {
"name": "yarn",
"version": "^4.6.0",
"onFail": "error"
}
},
"packageManager": "[email protected]",
"jest": {
"snapshotFormat": {
"escapeString": true,
Expand Down Expand Up @@ -124,7 +132,7 @@
"includeConsoleLog": true
}
]
]
},
"packageManager": "[email protected]"
],
"prettierPath": null
}
}
23 changes: 11 additions & 12 deletions scripts/autocomplete.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,17 @@ const SRC_FILENAME = 'global.html'
const OUT_DIR = 'src/editors/ace/docTooltip'

const TARGETS = [
'source_1',
'source_1_wasm',
'source_1_typed',
'source_2',
'source_2_typed',
'source_3',
'source_3_concurrent',
'source_3_typed',
'source_4',
'source_4_typed',
'source_4_explicit-control',
'External libraries'
"source_1",
"source_1_wasm",
"source_1_typed",
"source_2",
"source_2_typed",
"source_3",
"source_3_typed",
"source_4",
"source_4_typed",
"source_4_explicit-control",
"External libraries"
]

function newTitleNode(title, document) {
Expand Down
Loading
Loading