Rewrite: Stepper #1742
Draft
Rewrite: Stepper #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13645552196Details
💛 - Coveralls |
kavishsathia
force-pushed
the
rewrite/stepper
branch
from
694cb98 to
d817339
Compare
monnss69
reviewed
Apr 6, 2025
Comment on lines
+100
to
+110
| VariableDeclaration: (node: StepperVariableDeclaration) => { | ||
| if (node.kind === 'const') { | ||
| return ( | ||
| 'Constant ' + | ||
| node.declarations.map(ast => ast.id.name).join(', ') + | ||
| ' declared and substituted into the rest of block' | ||
| ) | ||
| } else { | ||
| return '...' | ||
| } | ||
| }, |
There was a problem hiding this comment.
Add an informative explanation for the var and let declarations.
Comment on lines
+155
to
+162
| const func: StepperArrowFunctionExpression = node.callee as StepperArrowFunctionExpression | ||
| if (func.name && isBuiltinFunction(func.name)) { | ||
| return `${func.name} runs` | ||
| // @ts-expect-error func.body.type can be StepperBlockExpression | ||
| } else if (func.body.type === 'BlockStatement') { | ||
| if (func.params.length === 0) { | ||
| return '() => {...}' + ' runs' | ||
| } |
There was a problem hiding this comment.
I think you should add a comment here to explain what the code below do since the name is not indicative.
Suggested change
| const func: StepperArrowFunctionExpression = node.callee as StepperArrowFunctionExpression | |
| if (func.name && isBuiltinFunction(func.name)) { | |
| return `${func.name} runs` | |
| // @ts-expect-error func.body.type can be StepperBlockExpression | |
| } else if (func.body.type === 'BlockStatement') { | |
| if (func.params.length === 0) { | |
| return '() => {...}' + ' runs' | |
| } | |
| // Determine whether the called function is built-in or not and create explanation accordingly | |
| const func: StepperArrowFunctionExpression = node.callee as StepperArrowFunctionExpression | |
| if (func.name && isBuiltinFunction(func.name)) { | |
| return `${func.name} runs` | |
| // @ts-expect-error func.body.type can be StepperBlockExpression | |
| } else if (func.body.type === 'BlockStatement') { | |
| if (func.params.length === 0) { | |
| return '() => {...}' + ' runs' | |
| } |
There was a problem hiding this comment.
I think this files is long and really lacking comments. However, no problem with the implementation.
kavishsathia
force-pushed
the
rewrite/stepper
branch
from
24dcf50 to
e596e75
Compare
…ifier, Literal and LogicalExpressions
kavishsathia
force-pushed
the
rewrite/stepper
branch
from
24b9bad to
20cb359
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to rewrite the stepper. The implementation is still in progress.
Type of change
How to test
Checklist