Skip to content

Rewrite:stepper Fix frontend to be compatible with js-slang rewrite/stepper #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

CATISNOTSODIUM
Copy link
Member

@CATISNOTSODIUM CATISNOTSODIUM commented Apr 8, 2025

Description

This PR aims to rewrite the code visualizer for the new stepper (source-academy/js-slang#1742) with new interactive features such as hovering on mu term for function definition. Instead of using React-ace library, this PR implements the code renderer from scratch while maintaining important features such as syntax highlighting and parentheses handling.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Remarks

  • src/commons/sideContent/content/_SideContentSubstVisualizer.tsx is the previous version. The new version is implemented in src/commons/sideContent/content/SideContentSubstVisualizer.tsx.
  • Do not forget to use the link js-slang library at the stepper branch (Rewrite: Stepper js-slang#1742) before starting the frontend.

Checklist

  • I have tested this code
  • I have updated the documentation

Sorry, something went wrong.

@CATISNOTSODIUM
Copy link
Member Author

image
It's weird that CI fails right at the format:ci stage. I don't get any errors when running on my machine. Maybe this frontend has to properly link with the rewrite/stepper branch in js-slang before testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants