-
Notifications
You must be signed in to change notification settings - Fork 171
Rewrite:stepper Fix frontend to be compatible with js-slang rewrite/stepper #3125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CATISNOTSODIUM
wants to merge
18
commits into
source-academy:master
Choose a base branch
from
CATISNOTSODIUM:stepper/rewrite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rewrite:stepper Fix frontend to be compatible with js-slang rewrite/stepper #3125
CATISNOTSODIUM
wants to merge
18
commits into
source-academy:master
from
CATISNOTSODIUM:stepper/rewrite
+919
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to rewrite the code visualizer for the new stepper (source-academy/js-slang#1742) with new interactive features such as hovering on mu term for function definition. Instead of using React-ace library, this PR implements the code renderer from scratch while maintaining important features such as syntax highlighting and parentheses handling.
Type of change
Remarks
src/commons/sideContent/content/_SideContentSubstVisualizer.tsx
is the previous version. The new version is implemented insrc/commons/sideContent/content/SideContentSubstVisualizer.tsx
.Checklist