Vesting: expose pending admin state and add cancel path - #416
Merged
Conversation
|
@Tobiloba0 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #363
This PR fixes the vesting contract’s invisible two-step admin transfer flow by making the pending admin readable on-chain and adding a real cancellation path for the current admin.
Changes:
Added pending_admin() to contracts/vesting so callers can confirm whether a transfer is in progress.
Added cancel_admin_proposal() so the current admin can clear a pending transfer without overwriting it.
Added unit coverage for pending admin visibility, canceling a proposal, and accepting after re-proposal.
Reused a shared pending-admin banner in the frontend so vesting and token admin flows present the same transfer-in-progress state consistently.
Surfaced vesting pending-admin status in the vesting lookup UI.
Validation:
cargo test -p soroban-vesting