Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: update README to reflect macOS changes #1393

Merged
merged 1 commit into from
Jul 24, 2017
Merged

ssh: update README to reflect macOS changes #1393

merged 1 commit into from
Jul 24, 2017

Conversation

slarew
Copy link
Contributor

@slarew slarew commented Jul 22, 2017

Proposed Changes

  • Remove statement in README of SSH module that states the module won't load on macOS.

@indrajitr
Copy link
Collaborator

This seems to be related to #1394. @slarew, would you consider merging the two PR's into a single one?
We haven't done this consistently so far, but it might be useful to have README (or related doc update) together with the actual code change.

@belak
Copy link
Collaborator

belak commented Jul 24, 2017

Normally when we do doc updates later, it's because we missed the doc update. It would be good to see these in the same PR if they're related.

@slarew
Copy link
Contributor Author

slarew commented Jul 24, 2017

This commit is partially related to #1394, but it's actually more of a fix for 658fffb when the README wasn't updated.

@belak belak merged commit e364eac into sorin-ionescu:master Jul 24, 2017
@belak
Copy link
Collaborator

belak commented Jul 24, 2017

That makes sense. Thanks for the clarification!

@slarew slarew deleted the sgl/sshreadmeupdate branch August 14, 2017 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slarew @indrajitr @belak