Skip to content

[FIX] ApiGatewayHandler send 오류 해결 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JungYoonShin merged 3 commits into from
Dec 30, 2025
Merged

[FIX] ApiGatewayHandler send 오류 해결 #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e170ec1
[REFACTOR] ApiGateWayHandler headerDto명 수정
JungYoonShin Dec 30, 2025
6ce6ddd
[FIX] ApiGatewayHandler - header에서 platfrom 파싱 에러 해결
JungYoonShin Dec 30, 2025
4d5e30a
[REFACTOR] ApiGateWayHandler headerDto명 수정
JungYoonShin Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/sopt/push/dto/ApiGatewayRequestDto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

import java.util.Map;

public record ApiGatewayRequestDto(RegisterHeaderDto header, Map<String, Object> body) {}
public record ApiGatewayRequestDto(RequestHeaderDto header, Map<String, Object> body) {}
2 changes: 1 addition & 1 deletion .../com/sopt/push/dto/RegisterHeaderDto.java → ...a/com/sopt/push/dto/RequestHeaderDto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
import com.sopt.push.enums.Platform;
import com.sopt.push.enums.Services;

public record RegisterHeaderDto(
public record RequestHeaderDto(
String transactionId, Services service, Platform platform, Actions action) {}
13 changes: 9 additions & 4 deletions src/main/java/com/sopt/push/lambda/ApiGatewayHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
import com.sopt.push.domain.DeviceTokenEntity;
import com.sopt.push.dto.ApiGatewayRequestDto;
import com.sopt.push.dto.CreateHistoryDto;
import com.sopt.push.dto.RegisterHeaderDto;
import com.sopt.push.dto.RequestDeleteTokenDto;
import com.sopt.push.dto.RequestHeaderDto;
import com.sopt.push.dto.RequestRegisterUserDto;
import com.sopt.push.dto.RequestSendAllPushMessageDto;
import com.sopt.push.dto.RequestSendPushMessageDto;
Expand Down Expand Up @@ -114,9 +114,14 @@ private ApiGatewayRequestDto extractRequest(APIGatewayProxyRequestEvent event) {
String transactionId = headers.get(HEADER_TRANSACTION_ID);
String serviceStr = headers.get(HEADER_SERVICE);
Actions action = Actions.fromValue(actionStr);
Platform platform = Platform.fromValue(platformStr);
RegisterHeaderDto header =
new RegisterHeaderDto(transactionId, Services.fromValue(serviceStr), platform, action);
Platform platform = null;

if (action == Actions.REGISTER || action == Actions.CANCEL) {
Copy link
Member

@seoyeonjin seoyeonjin Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저번에 조건 2개 이상이면 따로 변수로 빼기로 했던 거 맞나영 ?? 컨벤션으로 정했는지 궁금합니당

platform = Platform.fromValue(platformStr);
}

RequestHeaderDto header =
new RequestHeaderDto(transactionId, Services.fromValue(serviceStr), platform, action);

return new ApiGatewayRequestDto(header, body);
} catch (Exception e) {
Expand Down