[Feat/#1467] 솝트로그 앰잼탬프 적용 #1468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyobeen-Park
reviewed
Jan 7, 2026
| // 솝탬프 로그 | ||
| COMPLETED_MISSION(title = "완료미션", category = SoptLogCategory.SOPTAMP, url = "soptamp", count = { it.soptampCount ?: 0 }), | ||
| // 일반 솝탬프의 경우는 (기존) url = "soptamp" / 앱잼탬프만 appjamtamp 사용 (앱잼탬프 기간만) | ||
| COMPLETED_MISSION(title = "완료미션", category = SoptLogCategory.SOPTAMP, url = "appjamtamp", count = { it.soptampCount ?: 0 }), |
Contributor
There was a problem hiding this comment.
딥링크 처리하는 부분도 수정 부탁드려요!
| isError = false | ||
| ) | ||
| } | ||
| _isAppjamJoined.value = true |
Contributor
There was a problem hiding this comment.
앱잼 참여 여부가 api 성공 여부가 아닌 응답값 안에 담겨왔던 것 같은데 한 번만 더 확인 부탁드려도 될까요??
Contributor
Author
There was a problem hiding this comment.
이건 제가 실수를 했네요. 수정하도록 하겠습니다.
Contributor
아흑흑 그래서 서버드리븐으로 수정하는 것에 대해 슬랙 남겼었는데 아무도 못 본 것 같....😭😭 이번 스프린트 끝나고 나서 회의 때 언급 해볼게요..!! 그때 같이 논의해보자요😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
To Reviewers 📢