-
Notifications
You must be signed in to change notification settings - Fork 747
feat: Add user management CLI commands #4053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
manoharan-nexthop
wants to merge
1
commit into
sonic-net:master
Choose a base branch
from
manoharan-nexthop:sonic-net.user-management
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Add user management CLI commands #4053
manoharan-nexthop
wants to merge
1
commit into
sonic-net:master
from
manoharan-nexthop:sonic-net.user-management
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
07074c2
to
4c2b878
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
4c2b878
to
c4ad7ec
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
c4ad7ec
to
c1b2c4b
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
c1b2c4b
to
4c2b878
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
4c2b878
to
403fe8f
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
403fe8f
to
5c8dc01
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
5c8dc01
to
c4ad7ec
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
c4ad7ec
to
b17d729
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
b17d729
to
a301178
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add comprehensive CLI interface for SONiC local user management: - config user add/modify/delete - User lifecycle management - config user add-ssh-key/remove-ssh-key - SSH key management - config user import-existing - Import system users to SONiC - show user [username] - Display user information and status - show user roles - Display available roles and permissions Features: - Role-based access control (administrator/operator) - Secure password handling with confirmation prompts - SSH key format validation and management - CONFIG_DB integration for persistent configuration - Comprehensive input validation and error handling - Complete test suite with unit and integration tests Commands integrate with userd daemon for system-level user operations.
a301178
to
a9647a9
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This implementation addresses the User Management HLD requirements for user administration in SONiC. sonic-net/SONiC#2018
Add CLI interface for SONiC local user management:
How I did it
Features:
Commands integrate with userd daemon for system-level user operations.
How to verify it
Validated the CLI and its functionality.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)