Fix sonic-kdump-config for running commands with pipe #4045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exising code does not work because the commands with pipe are only able to run in shell
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
hi @qiluo-msft @saiarcot895 could you help to take a look? |
qiluo-msft
reviewed
Sep 26, 2025
| # | ||
| # @return The integer value X from USE_KDUMP=X in /etc/default/kdump-tools | ||
| def read_use_kdump(): | ||
| (rc, lines, err_str) = run_command("grep 'USE_KDUMP=.*' %s | cut -d = -f 2" % kdump_cfg, use_shell=False); |
There was a problem hiding this comment.
There is security related alert on this line by semgrep. ref: https://semgrep.dev/docs/cheat-sheets/python-command-injection#1b-shelltrue.
However in this case you may argue that the command is static constructed and no user input is allowed. It may be not future proof if the command become dynamic constructed.
To make static code analysis easier, let's prevent using shell=True. In this case, it is easy to completely python implementing both grep and cut. No need to run command. Could you explore?
There was a problem hiding this comment.
Alternative, you may want to use some options:
- getstatusoutput_noshell_pipe
- SysInfoProvider.run_command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The existing code does not work because the commands with pipe are only able to run in shell
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)