Add a new API connect_host to SonicV2Connector #147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 9, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Improve unit test for cover coverage.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@arlakshm @vmittal-msft this is needed for the aggregate Voq counters feature |
|
@kenneth-arista : to checkif we need this PR ? This code/repo i think is not being used anymore. |
vmittal-msft
approved these changes
Jun 14, 2025
Adjusted the unit test, so that we don't need this change anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature has been tracked in #1543
HLD PR: 1957
What did I do?
A new API is being added to sonicv2connector.cpp which can take the db name and host IP as an argument and connect us to the redis instance. The existing API needs the db_name and the host_ip and port (or unix_socket) is decoded using database_config.json. This API is tailored for use cases when you want to connect to the namespace redis instances from the same device. Our use case of aggregating VOQ counters across NPUs involves connecting to a redis instances over midplane IP hence the new API is needed.
How did I test it?
A unit test will be added to sonic-utilities and put this to use. Also verified on Arista chassis (DCS-7804-CH) which had 7800R3A-36D2-LC linecards with all changes related to this feature as present here sonic-net/SONiC#1957